New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support for Vite 3.1 #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
approved these changes
Sep 18, 2022
# Conflicts: # package.json # src/api.ts # src/types.ts
chore: lint examples
Updated pnpm to use 7.12.0 |
I need to review the pwa info plugin and the api, it seems we need to expose the info with some flags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
taze major -r -w
: pnpm to 7.12.0buildEnd
hook to build the pwa (once added the its integration will be updated)closeBundle
hook on build plugin with default order: will help to configure latest SvelteKit@antfu @benmccann the SvelteKit integration repo will be moved to the new org later, I've sent invitations to work directly on that repo.
Before merging this, we should release one last
0.12.8
version including PR 376 and 373.supersedes #370
closes #357