fix: nuxt 3.0.0 stable support #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
reviewed
Nov 17, 2022
userquin
reviewed
Nov 19, 2022
userquin
reviewed
Nov 21, 2022
README.md
Outdated
| @@ -335,9 +335,9 @@ export default defineConfig({ | |||
|
|
|||
|
|
|||
| <details> | |||
| <summary>Vue 3</summary><br> | |||
| <summary>Vue 3 / Vue 2.7+</summary><br> | |||
There was a problem hiding this comment.
I wouldn't have expected it to represent itself that way, but it was caused because my forked main branch was out of sync with your main branch; it was missing the commit with that addition. I merged your main into mine and it removed the change though. I also reviewed the files changed after the merge to make sure it only included the expected changes. Should be good now, @userquin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support with backward compatibility for the new Nuxt 3.0.0 stable release.
Linked Issues
fixes #249
Additional context
Since there is no test regarding this feature currently and it requires different versions of Nuxt installed to validate, so I manually tested via
examples/nuxt3.nuxt@3.0.0-rc.12runs correctly before my change.nuxt@3.0.0failed to run without my change.Cannot read properties of undefined (reading 'nuxt')nuxt@3.0.0runs correctly with my change.nuxt@3.0.0-rc.12runs correctly after my change. (backward compatible)