Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): default close swr cache #4470

Merged
merged 7 commits into from Jan 15, 2022
Merged

Conversation

chenshuai2144
Copy link
Contributor

  • fix(form): use new uuid function
  • fix(form): default close swr cache

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-4470.surge.sh

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

size-limit report

Path Size
packages/card/dist/card.js 21.8 KB (0%)
packages/descriptions/dist/descriptions.js 27.8 KB (0%)
packages/field/dist/field.js 143.07 KB (-0.02% 🔽)
packages/form/dist/form.js 100.51 KB (+0.19% 🔺)
packages/layout/dist/layout.js 138.6 KB (0%)
packages/list/dist/list.js 162.59 KB (0%)
packages/provider/dist/provider.js 24.43 KB (0%)
packages/skeleton/dist/skeleton.js 5.31 KB (0%)
packages/table/dist/table.js 101.02 KB (+0.02% 🔺)

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #4470 (a230c33) into master (542fcd6) will decrease coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   99.56%   99.52%   -0.04%     
==========================================
  Files         189      190       +1     
  Lines        6365     6378      +13     
  Branches     2320     2327       +7     
==========================================
+ Hits         6337     6348      +11     
- Misses         28       30       +2     
Impacted Files Coverage Δ
packages/table/src/utils/cellRenderToFromItem.tsx 98.80% <ø> (ø)
packages/utils/src/hooks/useDebounceFn/index.ts 100.00% <ø> (ø)
packages/utils/src/nanoid/index.ts 85.71% <85.71%> (ø)
packages/field/src/components/Select/index.tsx 100.00% <100.00%> (ø)
packages/form/src/BaseForm/createField.tsx 98.30% <100.00%> (+0.05%) ⬆️
packages/form/src/components/Field/index.tsx 93.75% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542fcd6...a230c33. Read the comment docs.

@chenshuai2144 chenshuai2144 changed the title form auto close swr fix(form): default close swr cache Jan 15, 2022
@chenshuai2144 chenshuai2144 merged commit 770a0fb into master Jan 15, 2022
@chenshuai2144 chenshuai2144 deleted the form-auto-close-swr branch January 15, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant