FloatButton 最新版本 (5.12.1) 依然报console warning

[Jeremy-Hibiki]

Reproduction link

Steps to reproduce

<React.StrictMode>
  <FloatButton.BackTop visibilityHeight={0} />
</React.StrictMode>

What is expected?

无报错

What is actually happening?

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of DomWrapper which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

Environment	Info
antd	5.12.1
React	18.x
System	Windows 11
Browser	Chrome 120.0.6099.71

---

相关：
#45387
#45390

[CYBYOB]

确实还有问题，本人尝试修复中~

[Jeremy-Hibiki]

还发现测试用例并没有检测到 console.error 被调用了

ant-design/components/float-button/__tests__/back-top.test.tsx

Lines 57 to 62 in 95b959c

	it('no error when BackTop work', () => {
	const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
	render(<BackTop visibilityHeight={0} />);
	expect(errSpy).not.toHaveBeenCalled();
	errSpy.mockRestore();
	});

改成如此可以被 jest 检测到 🤔

- it('no error when BackTop work', () => {
+ it('no error when BackTop work', async () => {
    const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
-   render(<BackTop visibilityHeight={0} />); 
+   await act(async () => {
+     const { container } = render(<BackTop visibilityHeight={0} />);
+     fireEvent.click(container.querySelector<HTMLButtonElement>('.ant-float-btn')!);
+   });
    expect(errSpy).not.toHaveBeenCalled();
    errSpy.mockRestore();
  });

  it('no error when BackTop work', async () => {
    const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
    await act(async () => {
      const { container } = render(<BackTop visibilityHeight={0} />);
      fireEvent.click(container.querySelector<HTMLButtonElement>('.ant-float-btn')!);
    });
    expect(errSpy).not.toHaveBeenCalled();
    errSpy.mockRestore();
  });

[yoyo837]

还发现测试用例并没有检测到 console.error 被调用了

ant-design/components/float-button/__tests__/back-top.test.tsx

Lines 57 to 62 in 95b959c

	it('no error when BackTop work', () => {
	const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
	render(<BackTop visibilityHeight={0} />);
	expect(errSpy).not.toHaveBeenCalled();
	errSpy.mockRestore();
	});

改成如此可以被 jest 检测到 🤔

- it('no error when BackTop work', () => {
+ it('no error when BackTop work', async () => {
    const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
-   render(<BackTop visibilityHeight={0} />); 
+   await act(async () => {
+     const { container } = render(<BackTop visibilityHeight={0} />);
+     fireEvent.click(container.querySelector<HTMLButtonElement>('.ant-float-btn')!);
+   });
    expect(errSpy).not.toHaveBeenCalled();
    errSpy.mockRestore();
  });

  it('no error when BackTop work', async () => {
    const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
    await act(async () => {
      const { container } = render(<BackTop visibilityHeight={0} />);
      fireEvent.click(container.querySelector<HTMLButtonElement>('.ant-float-btn')!);
    });
    expect(errSpy).not.toHaveBeenCalled();
    errSpy.mockRestore();
  });

来个PR？

[Jeremy-Hibiki]

来个PR？

前面没仔细看，这个能fail的原因是fireEvent.click没拿到DOM抛异常了

正确的 能fail用例的 PR 了

#46356

1. waitFakeTimer
2. 提到第一个用例前

在第一个用例后执行就mock失败 然后PASS，这个超出我能力范围了 😢

[afc163]

@CYBYOB 还在修么？

[nerdess]

Any news regarding this one?

I also get the same error when I wrap a Radio.Button with a Tooltip on latest antd (v5.11.5)

<Radio.Group>
  <Tooltip title='This activates Yes'>
	  <Radio.Button value='1'>
		  Yes
	  </Radio.Button>
  </Tooltip>
  <Tooltip title='This activates No'>
	  <Radio.Button value='0'>
		  No
	  </Radio.Button>
  </Tooltip>
</Radio.Group>

[github-actions]

Hello @Jeremy-Hibiki. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Jeremy-Hibiki，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

[afc163]

Trace #48709