Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify Transfer filterOption description #39916

Merged
merged 1 commit into from Dec 30, 2022
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 30, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #39907
close #39906

💡 Background and solution

Like Select/AutoComplete, Transfer filterOption prop works in searching situation. If you need to filter items in initial situation, please filter dataSource before passed to Transfer.

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 367.29 KB
./dist/antd-with-locales.min.js 422.4 KB

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a8b44d7) compared to base (cf41f81).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39916   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          591       591           
  Lines        10060     10071   +11     
  Branches      2719      2719           
=========================================
+ Hits         10060     10071   +11     
Impacted Files Coverage Δ
components/image/style/index.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 7db31a1 into master Dec 30, 2022
@afc163 afc163 deleted the docs/transfer-api branch December 30, 2022 09:21
@ivan-tkatchev
Copy link

Filtering dataSource before passing it to Transfer breaks correct display of items in the right (selected items) pane.
It should be possible to filter in initial situations separately for both panes.

yoyo837 pushed a commit that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer component's filterOption prop doesn't work unless something is entered in the search box
4 participants