Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker does not accept popupClassName when replacing Moment.js with day.js #35646

Closed
jamealg-jv opened this issue May 19, 2022 · 2 comments
Closed

Comments

@jamealg-jv
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Follow the steps on the Replace Moment.js documentation to replace with day.js: https://ant.design/docs/react/replace-moment
  2. Set popupClassName prop with a defined class
  3. Run and open the popup

What is expected?

The className is applied to the popup container

What is actually happening?

The className is not applied to the popup container

Environment Info
antd 4.20.4
React 17
System macOS Catalina 10.15.7
Browser Chrome 98.0.4758.102
@MadCcc
Copy link
Member

MadCcc commented May 20, 2022

Use dropdownClassName instead. popupClassName is only alias in TimePicker of antd, and is not work in Picker generated with generatePicker.
Maybe we should deprecate popupClassName and enable dropdownClassName for TimePicker to ensure consistency with DatePicker.

@MadCcc
Copy link
Member

MadCcc commented May 20, 2022

Trace in #34087

@MadCcc MadCcc closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants