Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid中的响应式断点breakpoint支持自定义 #34197

Closed
1 task done
Hitotsubashi opened this issue Feb 24, 2022 · 5 comments
Closed
1 task done

Grid中的响应式断点breakpoint支持自定义 #34197

Hitotsubashi opened this issue Feb 24, 2022 · 5 comments
Labels
💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@Hitotsubashi
Copy link

Hitotsubashi commented Feb 24, 2022

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

antd目前主要用于pc端web页面设计。当做pc端优先的响应式页面时,设计的断点通常以max-width去实现如:@media screen and (max-width: 768px),这样子小尺寸的样式就可以覆盖大尺寸的样式。而Grid中关于xs,xl等断点是写死成bootstrap4的以移动端优先的类型。

What does the proposed API look like?

可以参考ahooks的useResponsive(网址:https://ahooks.js.org/zh-CN/hooks/use-responsive#%E9%85%8D%E7%BD%AE)中写的自定义断点breakpoint的媒体查询语句。

@afc163
Copy link
Member

afc163 commented Feb 25, 2022

你是要自定义断点本身,还是想自定义断点生效的方式?

@afc163
Copy link
Member

afc163 commented Feb 25, 2022

Duplicate of #19694

@afc163 afc163 marked this as a duplicate of #19694 Feb 25, 2022
@Hitotsubashi
Copy link
Author

你是要自定义断点本身,还是想自定义断点生效的方式?

定义断点生效的方式,如md的生效方式为@media screen and (max-width: 768px)而不是@media screen and (min-width: 768px)

@afc163 afc163 added 💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Feb 27, 2022
@github-actions
Copy link
Contributor

Hello @Hitotsubashi. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Hitotsubashi,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@afc163
Copy link
Member

afc163 commented Jan 3, 2023

Supported in #39105

@afc163 afc163 closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Feature Request help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

2 participants