Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button 添加 href 被 disable 之后，依然可以跳转到新的 url #30207

Closed
1 task done
fubd opened this issue Apr 19, 2021 · 3 comments · Fixed by #30209
Closed
1 task done

Button 添加 href 被 disable 之后，依然可以跳转到新的 url #30207

fubd opened this issue Apr 19, 2021 · 3 comments · Fixed by #30209

Comments

@fubd
Copy link

fubd commented Apr 19, 2021 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Button 组件同时添加 disable 和 href 属性

What is expected?

被禁止跳转

What is actually happening?

跳转成功

Environment Info
antd 4.15.2
React 17.0.2
System mac os v11.1
Browser Chrome 88.0.4324.150
@afc163
Copy link
Member

afc163 commented Apr 19, 2021

原来这行代码是有用的：#30197

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 19, 2021

换方案 😂

@jameslahm
Copy link
Contributor

感觉可以revert #30197，cursor的样式交由用户控制？ 🤣

afc163 added a commit that referenced this issue Apr 19, 2021
@afc163
fix: Button with disabled and type="link" should not clickable
b0a4157 
close #30207
@afc163 afc163 mentioned this issue Apr 19, 2021
Merged
19 tasks
afc163 added a commit that referenced this issue Apr 19, 2021
@afc163
fix: Button with disabled and type="link" should not clickable
2d4da3a 
close #30207
afc163 added a commit that referenced this issue Apr 19, 2021
@afc163
fix: Button with disabled and type="link" should not clickable (#…
edb59bd 
…30209)

close #30207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Button with disabled and type="link" should not clickable ant-design/ant-design
4 participants
@afc163 @yoyo837 @fubd @jameslahm