Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(select): rewrite with hook #27318

Merged
merged 7 commits into from Oct 24, 2020
Merged

refactor(select): rewrite with hook #27318

merged 7 commits into from Oct 24, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Oct 23, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English rewrite with hook.
🇨🇳 Chinese 使用hook重写。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 23, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 23, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7184eb:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2020

Size Change: -149 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB -58 B (0%)
./dist/antd.min.js 277 kB -91 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 66.4 kB 0 B
./dist/antd.dark.min.css 67.7 kB 0 B
./dist/antd.min.css 66.4 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #27318 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7389      7380    -9     
  Branches      2074      2074           
=========================================
- Hits          7389      7380    -9     
Impacted Files Coverage Δ
components/auto-complete/index.tsx 100.00% <100.00%> (ø)
components/select/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0981d...a7184eb. Read the comment docs.

@hengkx hengkx requested a review from zombieJ October 24, 2020 07:57
@hengkx hengkx requested a review from zombieJ October 24, 2020 12:17
@zombieJ zombieJ merged commit b0245e7 into master Oct 24, 2020
@zombieJ zombieJ deleted the hooks branch October 24, 2020 12:33
@afc163
Copy link
Member

afc163 commented Oct 30, 2020

#27474

07akioni pushed a commit that referenced this pull request Nov 7, 2020
* refactor(select): rewrite with hook

* Update index.tsx

* Update index.tsx

* Update index.tsx

* fix test

* Update index.tsx

* Update index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants