Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc-dialog 中 forceRender 导致 .ant-modal-wrap display: none #25999

Closed
1 task done
LiJiahaoCoder opened this issue Aug 4, 2020 · 5 comments
Closed
1 task done

rc-dialog 中 forceRender 导致 .ant-modal-wrap display: none #25999

LiJiahaoCoder opened this issue Aug 4, 2020 · 5 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@LiJiahaoCoder
Copy link

LiJiahaoCoder commented Aug 4, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

自定义 Modal:

<Modal
  forceRender
  title={"修改初始密码"}
  visible={visible}
  closable={false}
  maskClosable={false}
  onCancel={onCancel}
>
  {/* children */}
</Modal>

App.js 使用:

<Modal visible />

visible 设为 true 时,同时使用 forceRenderrc-dialog 中逻辑会将 wrapperstyle.display 设为 none

What is expected?

在上述重现链接中,期望展示结果为:页面中展示 Modal 弹窗及 children

What is actually happening?

在上述重现链接中,实际展示结果为:空白页面

Environment Info
antd 4.0.0
React 16.12.0
System macOS Catalina 10.15.3
Browser Chrome 84.0.4147.89
@ant-design-bot
Copy link
Contributor

Hello @LiJiahaoCoder. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @LiJiahaoCoder, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Aug 4, 2020
@LiJiahaoCoder
Copy link
Author

rc-tools 中依赖已升级,是否考虑升级 rc-test 中的相关依赖,比如 rc-tools 中使用的最新 gulp v4.0.0,依赖版本不对称可能会引起一些问题。

@afc163
Copy link
Member

afc163 commented Aug 6, 2020

统一升级到 father。

@LiJiahaoCoder
Copy link
Author

LiJiahaoCoder commented Aug 9, 2020

已提pr,Travis构建失败,请检查Travis node版本配置是否正确。

@afc163
Copy link
Member

afc163 commented Aug 19, 2020

Fixed in react-component/dialog#194

@afc163 afc163 closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants