Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge master into feature #25829

Merged
merged 21 commits into from
Jul 27, 2020
Merged

chore: merge master into feature #25829

merged 21 commits into from
Jul 27, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jul 27, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Feature branch ci failed

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/avatar/demo/fallback.md
View rendered components/cascader/index.en-US.md
View rendered components/cascader/index.zh-CN.md
View rendered components/date-picker/demo/disabled.md
View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md
View rendered components/form/demo/time-related-controls.md
View rendered components/input/demo/align.md

zombieJ and others added 21 commits July 22, 2020 21:18
* docs: Update DatePicker docs and add legacy notice

* clean up

* only warning for QuarterPicker

* update docs

* fix lint

* note to warning
* fix: Table getCheckboxProps indeterminate not working

* feat: Table warn when set halfChecked using  getCheckboxProps

* chore: rename expand-chidren.md to tree-data.md
* refactor: avatar code

* fix: Fix Avatar fallback bug

close #25801

* add blank

* update demo
…ponent (#25823)

* Adds de_DE localisation for defaultValidateMessages for Form Component

* add de_DE localisation for default form validation messages
@afc163
Copy link
Member

afc163 commented Jul 27, 2020

按道理应该先把 master 同步到 feature 后,再合并回 master。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 27, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 27, 2020

@07akioni
Copy link
Contributor Author

按道理应该先把 master 同步到 feature 后,再合并回 master。

我是打算这么做的,现在 feature 那边的 CI 挂的有点多。我在发版之前肯定还是要同步回 master 的

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbc10c4:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #25829 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #25829   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files          374      374           
  Lines         7292     7300    +8     
  Branches      1988     1989    +1     
========================================
+ Hits          7257     7265    +8     
  Misses          35       35           
Impacted Files Coverage Δ
components/alert/index.tsx 100.00% <ø> (ø)
components/message/index.tsx 100.00% <ø> (ø)
components/radio/index.tsx 100.00% <ø> (ø)
components/avatar/avatar.tsx 100.00% <100.00%> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <100.00%> (ø)
components/date-picker/generatePicker/index.tsx 90.62% <100.00%> (+0.30%) ⬆️
components/locale/de_DE.tsx 100.00% <100.00%> (ø)
components/notification/index.tsx 100.00% <100.00%> (ø)
components/table/hooks/useSelection.tsx 99.56% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38f297...fbc10c4. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 27, 2020

master 和 feature 之间的合并记得不能用 squash merge。

@07akioni 07akioni merged commit 3247772 into feature Jul 27, 2020
@07akioni
Copy link
Contributor Author

OK,用的是普通的 merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants