Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci lint error #25828

Merged
merged 1 commit into from
Jul 27, 2020
Merged

fix: ci lint error #25828

merged 1 commit into from
Jul 27, 2020

Conversation

07akioni
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

eslint-plugin-react@7.20.4 causes lint error.

jsx-eslint/eslint-plugin-react@e20522c

components/back-top/index.tsx
  123:3  error  defaultProp "visibilityHeight" has no corresponding propTypes declaration  react/default-props-match-prop-types

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 27, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 27, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d32d2b6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #25828 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25828   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         374      374           
  Lines        7300     7300           
  Branches     2039     1989   -50     
=======================================
  Hits         7265     7265           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5f3b8...d32d2b6. Read the comment docs.

@07akioni 07akioni merged commit fbc10c4 into master Jul 27, 2020
@07akioni 07akioni deleted the fix-ci-lint branch July 27, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants