Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawer 在 getContainer={false} 两种共存时不清除 overflow: hidden #24821

Closed
1 task
jljsj33 opened this issue Jun 8, 2020 · 8 comments · Fixed by #25273
Closed
1 task

drawer 在 getContainer={false} 两种共存时不清除 overflow: hidden #24821

jljsj33 opened this issue Jun 8, 2020 · 8 comments · Fixed by #25273

Comments

@jljsj33
Copy link
Member

jljsj33 commented Jun 8, 2020 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://ant.design/components/drawer-cn/

Steps to reproduce

打开 《渲染在当前 DOM 》的 drawer 后再打开第一个，再关闭。。

What is expected?

What is actually happening?

Environment Info
antd undefined
React last
System osx
Browser chrome
@jljsj33 jljsj33 mentioned this issue Jun 8, 2020
Merged
@afc163
Copy link
Member

afc163 commented Jun 8, 2020

Duplicate of #21539

@afc163 afc163 marked this as a duplicate of #21539 Jun 8, 2020
@afc163 afc163 closed this as completed Jun 8, 2020
@jljsj33 jljsj33 reopened this Jun 8, 2020
@jljsj33
Copy link
Member Author

jljsj33 commented Jun 8, 2020

不是同一个问题

@afc163
Copy link
Member

afc163 commented Jun 8, 2020

和 #21539 (comment) 描述是一样的。

@jljsj33
Copy link
Member Author

jljsj33 commented Jun 8, 2020

这问题修不修？？？@afc163

@jljsj33 jljsj33 mentioned this issue Jun 8, 2020
Merged
@afc163
Copy link
Member

afc163 commented Jun 8, 2020

修啊

This was referenced Jun 8, 2020
Closed
Closed
jljsj33 added a commit to react-component/util that referenced this issue Jun 8, 2020
@jljsj33
Merge pull request #115 from react-component/fix-portalWrapper
b103101 
fix ant-design/ant-design#24821
@jljsj33
Copy link
Member Author

jljsj33 commented Jun 8, 2020

有点不敢修，，修了怕又出来个坑。。。

@jljsj33 jljsj33 reopened this Jun 8, 2020
@jljsj33 jljsj33 closed this as completed Jun 8, 2020
@jljsj33
Copy link
Member Author

jljsj33 commented Jun 8, 2020

rc-drawer v4.1.0

@jljsj33
Copy link
Member Author

jljsj33 commented Jun 8, 2020

@afc163 https://github.com/ant-design/ant-design/blob/master/package.json#L122, 这里自已改下

afc163 added a commit that referenced this issue Jun 29, 2020
@afc163
🆙 upgrade rc-drawer to fix scrollbar issue
993bef5 
close #24821
@afc163 afc163 mentioned this issue Jun 29, 2020
Merged
17 tasks
afc163 added a commit that referenced this issue Jun 29, 2020
@afc163
🆙 upgrade rc-drawer to fix scrollbar issue (#25273)
3e0d59b 
close #24821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Drawer scrollbar issue ant-design/ant-design
2 participants
@afc163 @jljsj33