Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert unknown to any #17249

Merged
merged 5 commits into from Jun 24, 2019
Merged

fix: revert unknown to any #17249

merged 5 commits into from Jun 24, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17245
close ant-design/ant-design-pro#4589

💡 Solution

Revert #17120 change in Form.

📝 Changelog

Language Changelog
🇺🇸 English Revert some types unknown to any introduced in #17120
🇨🇳 Chinese 回滚 #17120 引入的部分 unknown 类型为 any

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jun 23, 2019

Deploy preview for ant-design ready!

Built with commit 3f8589c

https://deploy-preview-17249--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #17249 into master will increase coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17249      +/-   ##
==========================================
+ Coverage   95.95%      96%   +0.04%     
==========================================
  Files         263      263              
  Lines        7351     7351              
  Branches     2055     2042      -13     
==========================================
+ Hits         7054     7057       +3     
+ Misses        295      292       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/message/index.tsx 93.75% <ø> (ø) ⬆️
components/mentions/index.tsx 100% <ø> (ø) ⬆️
components/auto-complete/index.tsx 88.09% <ø> (ø) ⬆️
components/auto-complete/InputElement.tsx 69.23% <ø> (ø) ⬆️
components/tabs/index.tsx 96.87% <ø> (ø) ⬆️
components/tree/Tree.tsx 96.87% <ø> (ø) ⬆️
components/checkbox/Checkbox.tsx 96% <ø> (ø) ⬆️
components/select/index.tsx 96.87% <ø> (ø) ⬆️
components/button/button.tsx 94.01% <ø> (ø) ⬆️
components/icon/IconFont.tsx 96% <ø> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5be7ce...3f8589c. Read the comment docs.

@afc163 afc163 changed the title fix: revert Form type unknown to any fix: revert some type unknown to any Jun 24, 2019
@afc163 afc163 changed the title fix: revert some type unknown to any fix: revert unknown to any Jun 24, 2019
@afc163
Copy link
Member Author

afc163 commented Jun 24, 2019

@Zzzen We should not rush into unknown in one time, maybe smoothly adjust in small place one by one.

@afc163 afc163 merged commit f6121aa into master Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-form-type branch June 24, 2019 04:02
@pr-triage pr-triage bot added the PR: merged label Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript errors when upgrading antd to 3.19.7 全新的ts项目,很多地方爆错
1 participant