Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SubMenu.tsx #17239

Merged
merged 1 commit into from Jun 22, 2019
Merged

Update SubMenu.tsx #17239

merged 1 commit into from Jun 22, 2019

Conversation

babbarankit
Copy link

popupOffset prop is missing in SubMenu

This is a Bug Fix

What's the background?

Typescript definition needed update.

馃挕 Solution

Typescript definition has been updated.

馃摑 Changelog

鈽戯笍 Self Check before Merge

TypeScript definition is updated.

  popupOffset prop is missing in SubMenu
@netlify
Copy link

netlify bot commented Jun 22, 2019

Deploy preview for ant-design ready!

Built with commit 0bb7f60

https://deploy-preview-17239--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #17239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17239   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2055     2015   -40     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage 螖
components/menu/SubMenu.tsx 90% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a3fb511...0bb7f60. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #17239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17239   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2055     2015   -40     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage 螖
components/menu/SubMenu.tsx 90% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a3fb511...0bb7f60. Read the comment docs.

@afc163 afc163 merged commit 40a38ff into ant-design:master Jun 22, 2019
@babbarankit babbarankit deleted the patch-2 branch June 23, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants