Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getPopupContainer of ConfigProvider not works on Modal #17132

Merged
merged 1 commit into from Jun 17, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

getPopupContainer of ConfigProvider not works on Modal

💡 Solution

Update logic

📝 Changelog

Language Changelog
🇺🇸 English Fix getPopupContainer of ConfigProvider not works on Modal
🇨🇳 Chinese 修复 ConfigProvider 的 getPopupContainer 对 Modal 无效的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jun 17, 2019

Deploy preview for ant-design ready!

Built with commit 17258c7

https://deploy-preview-17132--ant-design.netlify.com

@zombieJ zombieJ mentioned this pull request Jun 17, 2019
10 tasks
@zombieJ zombieJ changed the title Fix: getPopupContainer of ConfigProvider not works on Modal fix: getPopupContainer of ConfigProvider not works on Modal Jun 17, 2019
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #17132 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17132      +/-   ##
==========================================
+ Coverage   95.95%   95.95%   +<.01%     
==========================================
  Files         263      263              
  Lines        7344     7346       +2     
  Branches     2037     2049      +12     
==========================================
+ Hits         7047     7049       +2     
  Misses        295      295              
  Partials        2        2
Impacted Files Coverage Δ
components/modal/Modal.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1572c...17258c7. Read the comment docs.

@zombieJ zombieJ merged commit b402517 into master Jun 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the modal-config branch June 17, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant