Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RangerPicker style #17126

Merged
merged 2 commits into from Jun 17, 2019
Merged

fix: RangerPicker style #17126

merged 2 commits into from Jun 17, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

屏幕快照 2019-06-17 上午9 45 04

close #17124
close #17123

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix RangerPicker input style not align
🇨🇳 Chinese 修复 RangerPicker 输入框内容没有对齐的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jun 17, 2019

Deploy preview for ant-design ready!

Built with commit cc4f1d7

https://deploy-preview-17126--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Jun 17, 2019

Rebase master after #17128 merged

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #17126 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17126      +/-   ##
==========================================
- Coverage   95.96%   95.95%   -0.02%     
==========================================
  Files         263      263              
  Lines        7344     7344              
  Branches     2050     2050              
==========================================
- Hits         7048     7047       -1     
- Misses        294      295       +1     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️
components/back-top/index.tsx 92.06% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bfcab...cc4f1d7. Read the comment docs.

@zombieJ zombieJ merged commit dc1572c into master Jun 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-date-ranger branch June 17, 2019 04:24
@zombieJ zombieJ mentioned this pull request Jun 17, 2019
10 tasks
@lcx-seima
Copy link

我看 commit 只改了 ant-calendar-range-picker-inputant-calendar-range-picker-separator 也改了吧?

@beMySun
Copy link

beMySun commented Jun 17, 2019

Still not working in 3.19.5.

image

3.18.1 is Good.

image

@afc163
Copy link
Member

afc163 commented Jun 17, 2019

确实,separator 还在下面。

@wangjianio
Copy link

修复之前先用 3.19.3 吧,最近发版有点频繁啊

@sadianliaoer
Copy link

www

赶脚还是寻在问题

@jackple
Copy link

jackple commented Jun 21, 2019

@afc163
重要的是跟其他form组件不对齐了, 这个影响比3.19.5的修复的内容更大
image

@billwing
Copy link

billwing commented Jun 21, 2019

@jackple 我也在看这个问题,刚还原到3.19.3了😂

@zombieJ
Copy link
Member Author

zombieJ commented Jun 21, 2019

@jackple @billwing 这个 fix 已经 revert 了。3.19.6 还有这个问题吗?

@billwing
Copy link

@zombieJ 刚更新到3.19.6,没有发现这个问题🤝

@jackple
Copy link

jackple commented Jun 21, 2019

@zombieJ 我尝试升级后看到这样就回滚了, 稍候我再看看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangePicker 中 input 的 line-height 不正确
8 participants