New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: yarn webpack reports Critical dependency: the request of a dependency is an expression #748
Comments
@ganeshrn Once you fix that, I will add another change that makes webpack warnings be treated as errors, so we don't introduce more regressions accidentally. It seems that https://stackoverflow.com/questions/60092487/with-webpack-is-it-possible-to-force-warnings-to-be-treated-as-errors should help me do that. Maybe @fbricon could help on this issue as he is the brain behind telemetry extension. |
So, vscode-xml already webpacks vscode-redhat-telemetry and works fine. I checked the same warning is produced. I'm not a JS expert, but I think it's fine. Dunno if there's a way to tell webpack to SFTU about certain statements. |
That part is clearly going to help us find a solution for it. What is bit weird is that I did not see any warning while compiling the telemetry package locally. Maybe we could add a script that does use webpack on it just to test for this? I am not sure if that warning is really a reason to concern but if we can address it, it would be better. |
vscode-redhat-telemetry isn't webpacked. Some bits depend on nodejs, some others on DOM. Im not sure webpacking it won't cause issues down the line, but again not a JS expert. Anyways, https://github.com/redhat-developer/vscode-redhat-telemetry/pull/23/files#diff-3dbf6e739072174d75c3247910cbd0ac5f8972a7b0cea0ac00336526b474eaf5R93 should fix the current issue. |
For reference the issue seems to be caused by webpack/webpack#13865 |
Well, upgrading to 0.5.3 produced compilation errors, lots, but i am trying to investigate why...
|
yeah I'm seeing this too. FFS |
At least I am glad I am not the only one affected. It is quite confusing. I looked at the code and I was hoping we might have a way to bypass the loading of the default config but apparently that is not possible. I wonder if we should not better avoid using a variable and instead go for a static string. In the end webpack is expected to just load that data at compile time, so there is nothing dynamic about that. If anyone needs custom config, they can load it after, but the default should be static. |
try 0.5.4 now |
This should prevent accidental regression related to use of webpack. Related: #748
This should prevent accidental regression related to use of webpack. Related: #748
Introduction of telemetry introduce a regression on webpack where we can see this WARNING, which sounds more serious than a warning based on the "Critical dependency" part of it:
This will be produced on any platform and I have no clue what is effectively causing it but it can easily be seen that it is related to
@redhat-developer/vscode-redhat-telemetry
.The text was updated successfully, but these errors were encountered: