Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.9] Fix: nmcli bridge-slave fails with error #74125

Merged
merged 2 commits into from Apr 5, 2021
Merged

[stable-2.9] Fix: nmcli bridge-slave fails with error #74125

merged 2 commits into from Apr 5, 2021

Conversation

ccamacho
Copy link
Contributor

@ccamacho ccamacho commented Apr 5, 2021

This commit fixes the error for adding bridge slaves:

This fix is related to #42460 and #54617

Authored-by: Denis Kadyshev

SUMMARY

nmcli bridge-slave returns "Error: invalid or not allowed setting 'bridge-port'

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nmcli module

ADDITIONAL INFORMATION

From #68065

Example tasks:

- name: Add bridge
  nmcli:
    type: bridge
    conn_name: br0
    ip4: "{{ ansible_default_ipv4.address }}/{{ ansible_default_ipv4.netmask | ipaddr('prefix') }}"
    gw4: "{{ ansible_default_ipv4.gateway }}"
    state: present

- name: Add bridge slave
  nmcli:
    type: bridge-slave
    conn_name: "{{ ansible_default_ipv4.interface }}"
    ifname: "{{ ansible_default_ipv4.interface }}"
    master: br0
    state: present

Fails with:

Error: invalid or not allowed setting 'bridge-port': 'bridge-port' not among [connection, tun, 802-3-ethernet (ethernet), ethtool, match, ipv4, ipv6, tc, proxy].

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. collection Related to Ansible Collections work collection:community.general community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. small_patch core_review In order to be merged, this PR must follow the core review workflow. labels Apr 5, 2021
This commit fixes the error for adding bridge
slaves: nmcli bridge-slave returns "Error: invalid or not allowed setting 'bridge-port'

This fix is related to #42460, #54617, and #68065
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Apr 5, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 5, 2021
@relrod relrod merged commit 042d8ef into ansible:stable-2.9 Apr 5, 2021
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 19, 2021
@ansible ansible locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. collection:community.general collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants