add optional module_utils import support #73832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
core_review
Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement).
nitzmahone
force-pushed
the
optional_module_utils
branch
from
5db0260
to
72d0808
Compare
ansibot
added
ci_verified
ci_complete
ansibot
added
core_review
sivel
approved these changes
Mar 9, 2021
webknjaz
reviewed
Mar 9, 2021
| @@ -0,0 +1,84 @@ | |||
| #!/usr/bin/python | |||
| # Most of these names are only available via PluginLoader so pylint doesn't | |||
There was a problem hiding this comment.
Would it be reasonable to add the collection loader code to pylintrc?
mkrizek
removed
the
needs_triage
nitzmahone
added a commit
to nitzmahone/ansible
that referenced
this pull request
Mar 16, 2021
* add optional module_utils import support Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement). * sanity test fixes ci_complete (cherry-picked from 3e1f648)
nitzmahone
added a commit
to nitzmahone/ansible
that referenced
this pull request
Mar 16, 2021
* add optional module_utils import support Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement). * sanity test fixes ci_complete (cherry picked from commit 3e1f648)
nitzmahone
added a commit
to nitzmahone/ansible
that referenced
this pull request
Mar 16, 2021
* add optional module_utils import support Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement). * sanity test fixes ci_complete (cherry picked from commit 3e1f648)
relrod
pushed a commit
that referenced
this pull request
Apr 5, 2021
Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement). * sanity test fixes ci_complete (cherry-picked from 3e1f648)
relrod
pushed a commit
that referenced
this pull request
Apr 5, 2021
Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement). * sanity test fixes (cherry picked from commit 3e1f648)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Treat core and collections module_utils imports nested within any Python block statement (eg,
try,if) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime the module may implement).This is a collections "quality-of-life" issue that should make it easier for collections to use new Ansible features while still working on older Ansible versions (that have backported this fix; currently planned for 2.9/2.10 backport).
ISSUE TYPE
COMPONENT NAME
module_common
ADDITIONAL INFORMATION