docker_container: Always recreates the container when restart_policy is changed #65993

idelsink · 2019-12-20T10:11:48Z

SUMMARY

The docker_container module recreates a container when the restart_policy is changed. This can be changed using the docker update command.

ISSUE TYPE

Bug Report

COMPONENT NAME

docker_container

ANSIBLE VERSION

$ ansible --version
ansible 2.9.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/ingmar/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.7.5 (default, Oct 17 2019, 12:09:47) [GCC 9.2.1 20190827 (Red Hat 9.2.1-1)]

CONFIGURATION

$ ansible-config dump --only-changed
<empty>

OS / ENVIRONMENT

$ lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: Fedora
Description:    Fedora release 30 (Thirty)
Release:        30
Codename:       Thirty

STEPS TO REPRODUCE

Run the following playbook:

$ ansible-playbook docker-container-update.yml

- name: Container update restart_policy
  hosts: localhost
  tasks:
    - name: Container with restart_policy
      docker_container:
        name: restart_policy_example
        image: alpine
        state: present
        restart_policy: unless-stopped
        entrypoint: top

Change the restart_policy to always and run it again.

$ ansible-playbook docker-container-update.yml

- name: Container update restart_policy
  hosts: localhost
  tasks:
    - name: Container with restart_policy
      docker_container:
        name: restart_policy_example
        image: alpine
        state: present
        restart_policy: unless-stopped
        entrypoint: top

Notice by using the docker ps command that the container is recreated instead of updated.

EXPECTED RESULTS

I expect the container to be update with the new restart_policy by using the docker update command:

$ docker update --restart=<new policy>

ACTUAL RESULTS

The container is recreated instead of updated.
I currently run a command task before the container which updates the command.

# Update docker restart policy
- name: Update docker container restart policy
  command: "docker update --restart={{ (restart_policy == false) | ternary('no', restart_policy) }} {{ container }}"
  ignore_errors: true

The text was updated successfully, but these errors were encountered:

ansibot · 2019-12-20T10:13:39Z

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

idelsink · 2019-12-20T10:14:56Z

!component docker_container

idelsink · 2019-12-20T10:15:51Z

!component docker_container

Hmm I think that's not how it's supposed to work

winem · 2019-12-21T23:35:28Z

!component =lib/ansible/modules/cloud/docker/

winem · 2019-12-21T23:36:46Z

I am already working on a PR. Actually not a big deal but I have to put bit more time to do it right and not violate the currently very clear structure of the module.

ansibot · 2019-12-21T23:39:57Z

Files identified in the description:

lib/ansible/modules/cloud/docker

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibot · 2019-12-21T23:39:58Z

cc @DBendit @WojciechowskiPiotr @akshay196 @danihodovic @dariko @felixfontein @jwitko @kassiansun @tbouvet
click here for bot help

winem · 2019-12-21T23:45:55Z

!component =lib/ansible/modules/cloud/docker/docker_container.py

ansibot · 2019-12-21T23:49:17Z

Files identified in the description:

lib/ansible/modules/cloud/docker/docker_container.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibot · 2019-12-21T23:49:18Z

cc @chouseknecht @dusdanig @joshuaconner @softzilla @zfil
click here for bot help

felixfontein · 2019-12-22T00:09:21Z

Just put docker_container in the COMPONENT NAME field the next time.

idelsink · 2019-12-22T22:00:40Z

I am already working on a PR. Actually not a big deal but I have to put bit more time to do it right and not violate the currently very clear structure of the module.

Ah sounds great! I'm looking forward for the PR!

Just put docker_container in the COMPONENT NAME field the next time.

Sure, will do! A markdown link is not working then, noted.

winem · 2020-01-04T22:52:31Z

@idelsink the Docker documentation does not mention anything like a minimum required API version for example. Do you know any restrictions or dependencies like that?

I am just wondering why the restart policy was not handled like the other supported Docker update versions.

I'm quite busy at the moment but will create the PR end of next week, latest. :)

felixfontein · 2020-01-04T23:27:38Z

@winem does that mean you didn't start with the PR so far? In that case, do you mind if I don't wait and create a PR now?

winem · 2020-01-05T02:09:52Z

@felixfontein, sorry, was not sure if I get to it today but I actually just did and created the PR. Any review and feedback is highly appreciated.

…estart retries) wit… (#66192) * #65993 - update restart policy (restart policy & restart retries) without restarting the container * - proper indentation on the continuation-line - set restart_policy to the correct value independent from the api version * - move restart_policy definitions into the if block - add a new variable for the restart_policy configuration value * add changelog fragment * typo; minus -> underscore * rename changelog fragment to contain the correct module name * rename restart_policy_config_value to just restart_policy and refer to the correct dict values

…icy & restart retries) wit… (ansible#66192) * ansible#65993 - update restart policy (restart policy & restart retries) without restarting the container * - proper indentation on the continuation-line - set restart_policy to the correct value independent from the api version * - move restart_policy definitions into the if block - add a new variable for the restart_policy configuration value * add changelog fragment * typo; minus -> underscore * rename changelog fragment to contain the correct module name * rename restart_policy_config_value to just restart_policy and refer to the correct dict values (cherry picked from commit 02c126f)

…estart retries) wit… (#66192) * #65993 - update restart policy (restart policy & restart retries) without restarting the container * - proper indentation on the continuation-line - set restart_policy to the correct value independent from the api version * - move restart_policy definitions into the if block - add a new variable for the restart_policy configuration value * add changelog fragment * typo; minus -> underscore * rename changelog fragment to contain the correct module name * rename restart_policy_config_value to just restart_policy and refer to the correct dict values (cherry picked from commit 02c126f)

idelsink changed the title ~~docker_container: Always recreate the container when restart_policy is changed~~ docker_container: Always recreates the container when restart_policy is changed Dec 20, 2019

ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 20, 2019

ansibot added cloud docker module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 21, 2019

ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 22, 2019

winem mentioned this issue Jan 5, 2020

docker_container - #65993 - update restart policy (restart policy & restart retries) wit… #66192

Merged

ansibot added the has_pr This issue has an associated PR. label Jan 5, 2020

felixfontein closed this as completed in #66192 Jan 6, 2020

ansible locked and limited conversation to collaborators Feb 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docker_container: Always recreates the container when restart_policy is changed #65993

docker_container: Always recreates the container when restart_policy is changed #65993

idelsink commented Dec 20, 2019

ansibot commented Dec 20, 2019

idelsink commented Dec 20, 2019

idelsink commented Dec 20, 2019

winem commented Dec 21, 2019 •

edited

winem commented Dec 21, 2019

ansibot commented Dec 21, 2019

ansibot commented Dec 21, 2019

winem commented Dec 21, 2019

ansibot commented Dec 21, 2019

ansibot commented Dec 21, 2019

felixfontein commented Dec 22, 2019 •

edited

idelsink commented Dec 22, 2019

winem commented Jan 4, 2020

felixfontein commented Jan 4, 2020

winem commented Jan 5, 2020

docker_container: Always recreates the container when restart_policy is changed #65993

docker_container: Always recreates the container when restart_policy is changed #65993

Comments

idelsink commented Dec 20, 2019

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

CONFIGURATION

OS / ENVIRONMENT

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

ansibot commented Dec 20, 2019

idelsink commented Dec 20, 2019

idelsink commented Dec 20, 2019

winem commented Dec 21, 2019 • edited

winem commented Dec 21, 2019

ansibot commented Dec 21, 2019

ansibot commented Dec 21, 2019

winem commented Dec 21, 2019

ansibot commented Dec 21, 2019

ansibot commented Dec 21, 2019

felixfontein commented Dec 22, 2019 • edited

idelsink commented Dec 22, 2019

winem commented Jan 4, 2020

felixfontein commented Jan 4, 2020

winem commented Jan 5, 2020

winem commented Dec 21, 2019 •

edited

felixfontein commented Dec 22, 2019 •

edited