docker_service: defined cpus does not get casted into float

[yajo]

ISSUE TYPE

• Bug Report

COMPONENT NAME

docker_service

ANSIBLE VERSION

ansible 2.3.2.0
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Sep  5 2017, 08:53:59) [GCC 7.1.1 20170622 (Red Hat 7.1.1-3)]

CONFIGURATION

Nothing

OS / ENVIRONMENT

N/A

SUMMARY

Defining a service and trying to calculate the cpus parameter fails with:

Configuration error - The Compose file '/tmp/ansibled30aTJ/docker-compose.yml' is invalid because:
Unsupported config option for services.dind: 'cpus'

Possibly related to #17992.

STEPS TO REPRODUCE

- docker_service:
    pull: true
    state: present
    project_name: test
    definition:
      version: "2.2"
      services:
        dind:
          image: docker:dind
          cpus: "{{ ansible_processor_cores / 2 }}"

EXPECTED RESULTS

The cpus parameter should get casted to float or Ansible should have a way to force that, as I explained in #15249 (comment).

ACTUAL RESULTS

    "msg": "Configuration error - The Compose file '/tmp/ansibled30aTJ/docker-compose.yml' is invalid because:\nUnsupported config option for services.dind: 'cpus'"

[ansibot]

cc @chouseknecht
click here for bot help

[dagwieers]

If 'cpus` is defined as a float in the argument_spec, this would not be a problem. I assume today it is defined as an int, or not specified at all ?

[dagwieers]

There is a light at the end of the tunnel. We made a change to Jinja2 so we don't see all variable types changed into strings. See: pallets/jinja#708

[s-hertel]

Hopefully the fix to jinja2 gets merged soon. If someone needs a workaround I made a hackish fix for myself: s-hertel@559c498.

[yajo]

#32738 is merged now. How would that affect this issue at hand? Thanks.

[ansibot]

cc @felixfontein
click here for bot help

[ansibot]

cc @akshay196 @danihodovic @dariko @jwitko @kassiansun @tbouvet
click here for bot help

[ansibot]

cc @DBendit
click here for bot help

[felixfontein]

Please note that the docker_service module will be renamed to docker_compose in Ansible 2.8. You will be able to still use the old name, but you will receive a warning when doing so.

!component =lib/ansible/modules/cloud/docker/docker_compose.py

Also, please note that currently, nobody is actively maintaining the Ansible docker_service/docker_compose modules. If you are interested in working on this issue, please feel free to create a PR :) If you need any help, feel free to ping me or any other of the current docker_* module maintainers.

[ansibot]

cc @WojciechowskiPiotr
click here for bot help

[ansibot]

cc @sluther
click here for bot help

[sluther]

Can you confirm if this is still an issue or not after #32738 was merged?

needs_info

[ansibot]

@yajo This issue is waiting for your response. Please respond or the issue will be closed.

click here for bot help

[yajo]

Sorry, yes it works fine with jinja2_native enabled. Thanks!