[backport][release_2.2] Fix image build to override root homedir in /etc/passwd (#1027) #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* override root homedir in /etc/passwd * using only `HOME` envvar to override homedir causes mismatches with anything that asks for it a different way (eg, `echo ~root`) * kicking the can down the road on "why are we overriding /root as root's homedir anyway?" * more dynamic homedir handling * just make everybody's home /home/runner * restore ENV HOME override for builds * comment wording (cherry picked from commit c181daa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override root homedir in /etc/passwd
using only
HOMEenvvar to override homedir causes mismatches with anything that asks for it a different way (eg,echo ~root)kicking the can down the road on "why are we overriding /root as root's homedir anyway?"
more dynamic homedir handling
just make everybody's home /home/runner
restore ENV HOME override for builds
comment wording
(cherry picked from commit c181daa)