Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise name[casing] violation for notify task param #4149

Merged
merged 5 commits into from May 13, 2024
Merged

Raise name[casing] violation for notify task param #4149

merged 5 commits into from May 13, 2024

Conversation

cavcrosby
Copy link
Contributor

Fixes #4035.

@cavcrosby
Raise name[casing] violation for notify task param (ansible#4035)
f6442ea 
The become.yml playbook had its name[casing] violation fixed because
said playbook isn't expected to be tested for name[casing] violations.
@cavcrosby cavcrosby requested a review from a team as a code owner May 11, 2024 15:47
@cavcrosby cavcrosby requested review from Qalthos and priyamsahoo and removed request for a team May 11, 2024 15:47
@ssbarnea ssbarnea added the bug label May 13, 2024
@ssbarnea ssbarnea changed the title Raise name[casing] violation for notify task param (#4035) Raise name[casing] violation for notify task param May 13, 2024
@ssbarnea ssbarnea mentioned this pull request May 13, 2024
Merged
@ssbarnea ssbarnea disabled auto-merge May 13, 2024 16:07
@ssbarnea ssbarnea merged commit 23c046b into ansible:main May 13, 2024
23 of 25 checks passed
@cavcrosby cavcrosby deleted the raise-name-err-notify branch May 13, 2024 21:49
@Qalthos Qalthos mentioned this pull request May 15, 2024
Closed
@bsteinb bsteinb mentioned this pull request May 16, 2024
Open
@ssbarnea ssbarnea mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name[casing] error should be raised for notify task param
3 participants
@cavcrosby @ssbarnea @ansibuddy