-
Notifications
You must be signed in to change notification settings - Fork 687
Load rule ignores from external text file #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+133
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b76eb59
to
16c0936
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
mattclay
requested changes
Feb 9, 2023
Related: #3012 |
16c0936
to
2d0739a
Compare
This was referenced Feb 10, 2023
2d0739a
to
52ef34c
Compare
mattclay
previously requested changes
Feb 10, 2023
52ef34c
to
dd4548d
Compare
Dismissing my review now that ansible-test references have been removed.
cidrblock
approved these changes
Feb 10, 2023
mattclay
reviewed
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that ansible-test references have been removed, I'll leave the reviewing to the regular ansible-lint contributors.
e77b613
to
a3a7982
Compare
a3a7982
to
23ea1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible-lint will load skip rules from
.ansible-lint-ignore
file that is adjacent to its config file. The file format is very simple, containing the filename and the rule to be ignored. It also supports comments starting with#
.--generate-ignore
for dumping ignores for current violationsFixes: #1584
Fixes: #3012
Closes: #2934
Related: #2880