Correct schema refresh logic #2785
Conversation
ssbarnea
requested review from
a team,
audgirka,
priyamsahoo and
shatakshiiii
|
Answering #2729 (comment), since the issue is now locked. 😡 Thanks for the update @ssbarnea. Sorry for "raising my voice", but there have been numerous issues with this "thing" in the latest patch! releases of ansible-lint. I find it very annoying. |
What? Can't they be vendored into this repository for example? |
It is ok. We all make mistakes and try to do better after. I will release this today. If you want to keep an eye on open pull requests, you might help us get them right from first attempt. |
They were vendored since day one, in fact since two days ago, ansible-lint is the official source of the schemas. We deprecated the https://github.com/ansible/schemas project by including it inside ansible-lint, to ease the maintenance. We considered separated package but did not make sense, basically because inside a container, like https://github.com/ansible/creator-ee, we never update the packages. We wanted to ensure that someone that uses the linter on CI, github action or another pipeline, can benefit from using the latest schemas, without having to update the linter itself, especially because schemas changes are unlikely to cause any regressions. |
|
Ah, I answered before you added the word "updates" there. This makes more sense of course. |
ssbarnea
force-pushed
the
fix/schema-cache
branch
2 times, most recently
from
94e5c3e
to
b140fcb
Compare
- Ignore ConnectionResetError, reported on ansible#2729 (comment) - Stop refresh process on first found error, to avoid delays when networking is not available - Include etags for current schemas to avoid refreshing them - Update schemas from linter repo too if they changed Please note that offline mode does disable schema completely.
ssbarnea
force-pushed
the
fix/schema-cache
branch
from
b140fcb
to
0a7ee42
Compare
networking is not available
Please note that offline mode does disable schema update completely.