Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new --templates-path option #78

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add a new --templates-path option #78

wants to merge 7 commits into from

Conversation

NilashishC
Copy link
Collaborator

@NilashishC
Add --templates-path option
04f0a21 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC added the enhancement New feature or request label Jan 30, 2024
@NilashishC
fix tests
5004630 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Add a compat file
9388ef5 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ssbarnea ssbarnea marked this pull request as ready for review February 6, 2024 13:43
@ssbarnea ssbarnea requested a review from a team as a code owner February 6, 2024 13:43
@ssbarnea ssbarnea requested review from Qalthos and priyamsahoo and removed request for a team February 6, 2024 13:43
@ssbarnea ssbarnea enabled auto-merge (squash) February 7, 2024 14:21
@cidrblock
Copy link
Collaborator

I think we should hold off on this until we test out pluggy as a long term way to extend creator.

@cidrblock cidrblock marked this pull request as draft February 7, 2024 14:38
ssbarnea
ssbarnea requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure that coverage does not go down with this new feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flags to specify template source components
3 participants
@NilashishC @cidrblock @ssbarnea