Relax pluggy version dependency #3239
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pluggy module was added back in 2019 - there are newer releases now, and we can expect other projects to depend on the 1.0 one - it would then conflict with molecule, preventing developers to run smoothly there unit tests.
cjeanner
requested review from
ssbarnea,
tadeboro and
webknjaz
as code owners
ssbarnea
approved these changes
Sep 17, 2021
|
Oh, Thanks Sorin! I should have pinged you earlier :). |
ssbarnea
changed the title
tadeboro
approved these changes
Sep 17, 2021
tadeboro
pushed a commit
that referenced
this pull request
Oct 1, 2021
Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Backport to stable/3.4: 💚 backport PR created✅ Backport PR branch: Backported as #3256 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 2, 2021
Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com> (cherry picked from commit 212b01c)
ssbarnea
pushed a commit
that referenced
this pull request
Oct 2, 2021
Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com> (cherry picked from commit 212b01c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pluggy module was added back in 2019 - there are newer releases now,
and we can expect other projects to depend on the 1.0 one - it would
then conflict with molecule, preventing developers to run smoothly there
unit tests.
PR Type