Use portable cache from ansible-compat #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Aug 12, 2021
webknjaz
reviewed
Aug 12, 2021
webknjaz
reviewed
Aug 12, 2021
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Aug 25, 2021
This should make it much easier for use to use the newer caching functions in python across our projects. Related: ansible/molecule#3180
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Aug 26, 2021
This should make it much easier for use to use the newer caching functions in python across our projects. Related: ansible/molecule#3180
ssbarnea
changed the title
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Aug 26, 2021
ssbarnea
added a commit
to ansible-community/molecule-docker
that referenced
this pull request
Aug 26, 2021
ssbarnea
force-pushed
the
fix/lru
branch
2 times, most recently
from
e5ae0a7
to
b870a60
Compare
tadeboro
suggested changes
Aug 31, 2021
Sorted. Got combined by mistake while working on different changes. |
ssbarnea
added a commit
to ansible-community/molecule-hetznercloud
that referenced
this pull request
Sep 2, 2021
This makes the driver version with future versions of molecule, which will no longer have the cache in them. Same kind of change was already merged in two other drivers podman and docker. Related: ansible/molecule#3180
ssbarnea
added a commit
to ansible-community/molecule-hetznercloud
that referenced
this pull request
Sep 2, 2021
This makes the driver version with future versions of molecule, which will no longer have the cache in them. Same kind of change was already merged in two other drivers podman and docker. Related: ansible/molecule#3180
This simplifies use of caching across multiple versions of Python. Three molecule plugins required patching before this change as they were importing the @cache from molecule.
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Sep 2, 2021
This should make it much easier for use to use the newer caching functions in python across our projects. Related: ansible/molecule#3180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies use of caching across multiple versions of Python.
Implementation is inspired from the the approach taken by https://github.com/apache/airflow/ project.
Related: python/mypy#1362