Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add win_command/win_shell to no-free-form modules #2596

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Add win_command/win_shell to no-free-form modules #2596

merged 2 commits into from
Oct 13, 2022

Conversation

nre-ableton
Copy link
Contributor

@nre-ableton nre-ableton commented Oct 12, 2022 •
edited by ssbarnea

#2586 softened the no-free-form rule, but unfortunately missed the Windows equivalents for these modules.

Fixes: #2597

@nre-ableton nre-ableton requested a review from a team as a code owner October 12, 2022 15:18
@ssbarnea ssbarnea added the bug label Oct 12, 2022
ssbarnea
ssbarnea requested changes Oct 12, 2022
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Can you also add the FQCN of these to the list ansible.windows. for windows ones and ansible.builtin. for the old ones, so we cover for all forms.

@nre-ableton nre-ableton force-pushed the nre/main/free-form-urls-win-modules branch from da45b8b to 7220f8b Compare October 13, 2022 07:36
@nre-ableton nre-ableton requested review from ssbarnea and removed request for ganeshrn, cidrblock and priyamsahoo October 13, 2022 07:36
@nre-ableton
Copy link
Contributor Author

@ssbarnea Great point! Does it look better now?

@ssbarnea ssbarnea merged commit 644553e into ansible:main Oct 13, 2022
@ssbarnea ssbarnea mentioned this pull request Oct 13, 2022
Closed
@nre-ableton nre-ableton deleted the nre/main/free-form-urls-win-modules branch October 13, 2022 09:59
@nre-ableton
Copy link
Contributor Author

@ssbarnea Thanks for the quick merge. 👍

@ssbarnea ssbarnea mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-free-form: test could be a bit more precise
2 participants
@nre-ableton @ssbarnea