Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace template-instead-of-copy with avoid-implicit[copy-content] #2512

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 28, 2022

  • Replace to aggressive and indiscriminate rule template-instead-of-copy with new one that only discourages the implicit stringification on copy content.
  • New rule will be just a warning

Fixes: #2501

Copy link
Contributor

@GhostLyrics GhostLyrics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change from double brackets to single brackets intentional?

@ssbarnea

This comment was marked as outdated.

@ssbarnea ssbarnea changed the title template-instead-of-copy: update documentations template-instead-of-copy: reduce number of false positives Sep 29, 2022
@ssbarnea

This comment was marked as outdated.

@ssbarnea ssbarnea changed the title template-instead-of-copy: reduce number of false positives Replace template-instead-of-copy with avoid-implicit[copy-content] Sep 29, 2022
@ssbarnea ssbarnea added this to the 6.8.0 milestone Sep 29, 2022
@ssbarnea ssbarnea merged commit 0e6cdef into ansible:main Sep 29, 2022
@ssbarnea ssbarnea deleted the fix/copy-docs branch September 29, 2022 20:38
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: copy/template rule needs better reasoning
2 participants