Configure root logger instead of package logger #1773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
This was discussed internally; the goal is to make it so that rules
which set up their own logger are still subject to the global rules
of ansible-lint particularly with regard to our verbosity/quietness
flags.
To accomodate for using the root logger, the logging levels of -q and
-qq had to change slightly. This is because the default log level of
the root logger is WARNING, and we want to avoid setting it to NOTSET
which would allow everything by default. To work around this, we now
make our default be WARNING as well. -q becomes ERROR, and -qq
becomes CRITICAL which we previously didn't have.
Test Plan:
Signed-off-by: Rick Elrod rick@elrod.me