-
Notifications
You must be signed in to change notification settings - Fork 695
Make exclude files work with progressive mode #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make exclude files work with progressive mode #1767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you do not mind but moving the code into file-utils should be separated from the effective progressive mode bugfix. Please make separated PRs, preferably the function moving should be first move.
Ok, will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @clementmartin, for your contribution! I have nothing to add when it comes to the idea, but I added a few suggestions that touch upon the implementation.
0731f42
to
391bfd6
Compare
@clementmartin, I see you resolved my comments without updating the code. Did something strange happen during the rebase and force-push? |
@tadeboro I don't know, I've used the batch commit feature in the files section and didn't remark anything abnormal... |
Well, something went awry because my suggestions were not applied ;) Also, you have a linting issue in the file that needs fixing. |
If
options.progressive
is set,options.exclude_files
are not updated in_previous-revision
, rendering them useless. This pull requests handles that.Fixes: #1766