Make exclude files work with progressive mode #1767
Merged
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested changes
Nov 30, 2021
|
Ok, will do! |
ssbarnea
changed the title
ssbarnea
approved these changes
Nov 30, 2021
tadeboro
suggested changes
Nov 30, 2021
There was a problem hiding this comment.
Thank you, @clementmartin, for your contribution! I have nothing to add when it comes to the idea, but I added a few suggestions that touch upon the implementation.
clementmartin
force-pushed
the
progressive-exclude-files
branch
from
0731f42 to
391bfd6
Compare
|
@clementmartin, I see you resolved my comments without updating the code. Did something strange happen during the rebase and force-push? |
|
@tadeboro I don't know, I've used the batch commit feature in the files section and didn't remark anything abnormal... |
Well, something went awry because my suggestions were not applied ;) Also, you have a linting issue in the file that needs fixing. |
added 2 commits
November 30, 2021 20:22
tadeboro
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
options.progressiveis set,options.exclude_filesare not updated in_previous-revision, rendering them useless. This pull requests handles that.Fixes: #1766