Skip to content

Make exclude files work with progressive mode #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

clementmartin
Copy link
Contributor

@clementmartin clementmartin commented Nov 30, 2021

If options.progressive is set, options.exclude_files are not updated in _previous-revision, rendering them useless. This pull requests handles that.

Fixes: #1766

@clementmartin clementmartin requested a review from a team as a code owner November 30, 2021 08:51
@ssbarnea ssbarnea added the bug label Nov 30, 2021
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you do not mind but moving the code into file-utils should be separated from the effective progressive mode bugfix. Please make separated PRs, preferably the function moving should be first move.

@clementmartin
Copy link
Contributor Author

Ok, will do!

@ssbarnea ssbarnea changed the title Progressive exclude files Make exclude files work with progressive mode Nov 30, 2021
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @clementmartin, for your contribution! I have nothing to add when it comes to the idea, but I added a few suggestions that touch upon the implementation.

Clément Martin added 2 commits November 30, 2021 19:01

Verified

This commit was signed with the committer’s verified signature.
fvictorio Franco Victorio
@clementmartin clementmartin force-pushed the progressive-exclude-files branch from 0731f42 to 391bfd6 Compare November 30, 2021 18:03
@tadeboro
Copy link
Contributor

@clementmartin, I see you resolved my comments without updating the code. Did something strange happen during the rebase and force-push?

@clementmartin
Copy link
Contributor Author

@tadeboro I don't know, I've used the batch commit feature in the files section and didn't remark anything abnormal...

@tadeboro
Copy link
Contributor

@tadeboro I don't know, I've used the batch commit feature in the files section and didn't remark anything abnormal...

Well, something went awry because my suggestions were not applied ;) Also, you have a linting issue in the file that needs fixing.

@ssbarnea ssbarnea merged commit fd4a746 into ansible:main Dec 1, 2021
@clementmartin clementmartin deleted the progressive-exclude-files branch December 2, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclude_paths config option fails on progressive mode
3 participants