Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on the group_by install_status parameter of the inventory plugin to include information about the expected data type #81

Open
mrmibrown opened this issue Jun 23, 2021 · 3 comments
Labels

Comments

@mrmibrown
Copy link

SUMMARY

Elaborate on the group_by install_status parameter of the inventory plugin to include information about the expected data type. This parameter is expecting a 'choice list' index(integer) but it is not explained clearly leading to situations where strings are passed resulting in invalid queries:

Invalid:

plugin: servicenow.itsm.now
columns:
  - install_status
group_by:
  install_status:
    includes:
      - Installed   # HERE

Valid:

plugin: servicenow.itsm.now
columns:
  - install_status
group_by:
  install_status:
    includes:
      - 1    # HERE
ISSUE TYPE
  • Documentation Report
COMPONENT NAME

plugin

ANSIBLE VERSION
@Akasurde
Copy link
Member

Akasurde commented Jun 24, 2021

@mrmibrown Thanks for reporting this issue. Could you please check if #78 works for you and let us know?

@Akasurde Akasurde added type/documentation Improvements or additions to documentation has_pr verified labels Jun 24, 2021
@tadeboro
Copy link
Contributor

I think updating examples is not enough in this case. It is an OK(ish) workaround for the time being, but we really need to do better. At a minimum, we should make sure that users can use display values in the filter specification. This will make sure the filter definition and the resulting group names at least somewhat match.

We have some work planned in this direction for collection already, so getting there should not be too problematic.

@Akasurde Akasurde added type/bug Something isn't working and removed type/documentation Improvements or additions to documentation labels Jun 24, 2021
@Akasurde Akasurde removed the has_pr label Jun 24, 2021
@Akasurde
Copy link
Member

@tadeboro Thanks for the information.

@tima tima added this to To do in servicenow.itsm v2.0 Apr 7, 2022
@tima tima removed this from To do in servicenow.itsm v2.0 Aug 24, 2022
@tima tima added this to To do in servicenow.itsm v2.0.1 via automation Aug 24, 2022
@Akasurde Akasurde removed this from To do in servicenow.itsm v2.0.1 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants