Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add extra parameter to helm diff #628

Open
PPACI opened this issue Jun 12, 2023 · 1 comment
Open

Proposal: Add extra parameter to helm diff #628

PPACI opened this issue Jun 12, 2023 · 1 comment
Labels
type/proposal Proposal for a new feature, process or initiative

Comments

@PPACI
Copy link

PPACI commented Jun 12, 2023

def helmdiff_check(

Using this function, helm diff is used when available. This is a great help!
Though, in some case, it would be useful to add some extra args such as --show-secrets.

I was thinking of adding the content of an environment variable such as `ANSIBLE_HELM_DIFF_EXTRAVARS".

I could take care of writing a pull request with implementation + tests. What do you think?

@gravesm gravesm added the type/proposal Proposal for a new feature, process or initiative label Jun 13, 2023
@PPACI
Copy link
Author

PPACI commented Dec 8, 2023

Hi
I would like to recomment on this.
I will propose a pull request using the ANSIBLE_HELM_DIFF_EXTRAVARS mechanism.
Let me know if you prefer me to implement this in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Proposal for a new feature, process or initiative
Projects
None yet
Development

No branches or pull requests

2 participants