Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenShift Project/ProjectRequest #645

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: OpenShift Project/ProjectRequest #645

wants to merge 2 commits into from

Conversation

tenstad
Copy link

@tenstad tenstad commented Sep 7, 2023 •
edited

SUMMARY

Fixes #623

Introduces Project/ProjectRequest translation logic that enables working with both

k8s:
  api_version: project.openshift.io/v1
  kind: Project
  resource_definition:
    annotations:
      openshift.io/display-name: Foo
      openshift.io/description: Bar

and

k8s:
  api_version: project.openshift.io/v1
  kind: ProjectRequest
  resource_definition:
    displayName: Foo
    description: Bar
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

ADDITIONAL INFORMATION

Should all this custom OpenShift logic really be in a kubernetes core plugin?

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/aeeb145d102147adb00e3ca056826d69

✔️ ansible-galaxy-importer SUCCESS in 3m 21s
✔️ build-ansible-collection SUCCESS in 6m 42s

@tenstad
Copy link
Author

tenstad commented Sep 8, 2023

@gravesm what do you think? ☺️

@erikgb
Copy link

erikgb commented Dec 4, 2023

@abikouo Maybe you have a chance to review this? We are stuck on Ansible 6 because of this bug. Are no one else using this collection with Openshift? We could migrate to the community.okd collection, but I would prefer not to extend the vendor lock-in situation. Since there are already hacks for the borked OpenShift Project API in this collection, I think this PR does not make the situation worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Openshift ProjectRequest attempts to patch
2 participants
@tenstad @erikgb