Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parse_kev_term into the hashi_vault lookup #351

Open
briantist opened this issue Feb 26, 2023 · 0 comments
Open

Move parse_kev_term into the hashi_vault lookup #351

briantist opened this issue Feb 26, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@briantist
Copy link
Collaborator

SUMMARY

https://github.com/ansible-collections/community.hashi_vault/blob/main/plugins/plugin_utils/_hashi_vault_lookup_base.py#L30-L47

parse_kev_term is used to parse key=value pairs from a term string for filling in options. It's only used in the hashi_vault lookup, but it currently exists in our lookup base class, and it really doesn't need to be there.

Since we plan to not support this method of supplying options in any other plugins, we should move it into the one lookup where it's used.

ISSUE TYPE
  • Feature Idea
@briantist briantist added the good first issue Good for newcomers label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant