Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests - consider flake8-pytest-style #132

Open
briantist opened this issue Aug 26, 2021 · 0 comments
Open

tests - consider flake8-pytest-style #132

briantist opened this issue Aug 26, 2021 · 0 comments
Assignees
Labels
ci Specifically related to the CI on this repo tests Adds or modifies tests

Comments

@briantist
Copy link
Collaborator

SUMMARY

As suggested in: https://github.com/ansible-collections/community.hashi_vault/pull/128/files#r696697212

The collection has a fair amount of unit tests (and growing) and it would be good to catch issues and try to enforce some style consistency there.

thoughts:

  • local usage: right now all tests are run with ansible-test, so will think about how to encourage folks to run it locally before CI
  • in CI: would fit nicely into the unit test jobs probably
  • can rules/settings be defined in a way that will work for local/CI runs and also work well with IDE/editor integration?
ISSUE TYPE
  • Feature Idea
COMPONENT NAME
ADDITIONAL INFORMATION
@briantist briantist added tests Adds or modifies tests ci Specifically related to the CI on this repo labels Aug 26, 2021
@briantist briantist self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Specifically related to the CI on this repo tests Adds or modifies tests
Projects
Development

No branches or pull requests

1 participant