Add generate_switchport_trunk func
#1062
Merged
+224
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alezkv Can you please add a changelog and tests to justify the changes you have added? |
|
@alezkv unit tests should be fine! |
|
@KB-perByte, I have added some unit tests. Could you please check them? |
This should fix ansible-collections#1061 by splitting switchport vlan commands into several if resulted vlan lexeme will be more than 220 symbols.
alezkv
force-pushed
the
generate-switchport
branch
from
85ce80e
to
bcb0db6
Compare
|
Cc @roverflow |
|
@alezkv PR looks great, doing some more testing, in the mean time can you add a changelog, you can take any other PR as reference for this. Thanks! |
|
Added changelog entry |
|
@roverflow humble reminder on this |
|
Hey @alezkv the changes look good to me, you need to make changes to the unit tests so that sanity passes. CC @roverflow |
|
@alezkv the UTs fail now! |
|
@KB-perByte, indeed, my apologies for the confusion. For now, sanity and unit tests should suffice, at least for one variant of the matrix. |
KB-perByte
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1061
Split single
swtichport {type} vlancommand into several if resulted vlan lexeme will be more than 220 symbols.ISSUE TYPE
COMPONENT NAME
cisco.ios.l2_interfaces