Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with error if default branch is not set in non prs #235

Merged
merged 2 commits into from Jan 5, 2023

Conversation

sbe-arg
Copy link
Collaborator

@sbe-arg sbe-arg commented Jan 4, 2023

This not really a hotfix more like a user warning to set the default_branch if using a workflow approach that does not contemplate PRs.

Open question, do we want to try to identify if master or main exist and define that as default branch as workaround?

@sbe-arg sbe-arg requested a review from sammcj January 4, 2023 08:59
@sbe-arg sbe-arg mentioned this pull request Jan 4, 2023
Wording fixups


Actually try to ind the branch naively if null


try to find the branch natively if no on prs
@sbe-arg sbe-arg merged commit 2c9e17c into master Jan 5, 2023
@sbe-arg sbe-arg deleted the poc_default_branch-hotfix branch January 5, 2023 00:32
@dgokcin
Copy link

dgokcin commented Jan 5, 2023

this update caused the following issue. it broke all of my production workflows. I do not think that this was a hotfix. I think this was a braking change.

#236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants