Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build and push new prebuilt docker image #219

Merged
merged 7 commits into from Dec 6, 2022

Conversation

sammcj
Copy link
Collaborator

@sammcj sammcj commented Dec 5, 2022

Summary of changes

Follow up to #201, hopefully this fixes the permissions - both the previous PR and this one worked on my fork, but as I'm not an admin on this repo it's a bit hard to test.

Note that the pre-merge test will not pass until this is merged as the container image doesn't exist on this repo yet.

Do any of the followings changes break current behaviour or configuration?

  • NO

How changes have been tested

  • Limited ability to test due to requiring ownership of this repo which I don't have.

List any unknowns

@sammcj sammcj requested a review from sbe-arg December 5, 2022 06:51
@sammcj sammcj self-assigned this Dec 5, 2022
@sammcj
Copy link
Collaborator Author

sammcj commented Dec 5, 2022

@sbe-arg pretty please, if this doesn't work, I'll submit one more PR to revert them both and I'll have to do further testing on my fork.

@sammcj
Copy link
Collaborator Author

sammcj commented Dec 5, 2022

ping @sbe-arg

@sammcj sammcj closed this Dec 6, 2022
@sammcj sammcj reopened this Dec 6, 2022
@sammcj sammcj merged commit 8aac693 into anothrNick:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants