Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-output to use GITHUB_OUTPUT file #206

Merged
merged 4 commits into from Nov 1, 2022

Conversation

JP-Dhabolt
Copy link
Contributor

Resolves #205

Summary of changes

Updates how output is being set to remove warnings and prevent breakage once Github removes support for the set-output echo statements.

Do any of the followings changes break current behaviour or configuration?

  • NO

How changes have been tested

  • Tested locally by setting the environment variable to /dev/stdout to see the correct output.
  • test.yml workflow should validate the functionality by executing this changed action.

List any unknowns

  • Should not be any unknowns, as this is following Github's documentation on how to set outputs as of 2022-10-11

Signed-off-by: JP Dhabolt <john.p.dhabolt@gmail.com>
Copy link
Collaborator

@sbe-arg sbe-arg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, just a simple comment otherwise looks god.

entrypoint.sh Outdated Show resolved Hide resolved
@sbe-arg sbe-arg added the enhancement New feature or request label Oct 27, 2022
Signed-off-by: JP Dhabolt <john.p.dhabolt@gmail.com>
Signed-off-by: JP Dhabolt <john.p.dhabolt@gmail.com>
entrypoint.sh Outdated Show resolved Hide resolved
Signed-off-by: JP Dhabolt <john.p.dhabolt@gmail.com>
@Sandra-headscape
Copy link

Sandra-headscape commented Oct 31, 2022

Hi, this seems ready to go? I'd like to get this into my workflow without using the fork - thanks (:

update 18Nov2022: am currently using 1.52.0, but upon checking realised this wasn't released as a new version as the build failed - https://github.com/anothrNick/github-tag-action/actions/runs/3372412451/jobs/5595804270

did i miss something? thanks (:

@sbe-arg sbe-arg merged commit be61601 into anothrNick:master Nov 1, 2022
lobner added a commit to BiQ/github-tag-action that referenced this pull request Nov 12, 2022
Update set-output to use GITHUB_OUTPUT file (anothrNick#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert set-output to use GITHUB_OUTPUT file
3 participants