Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safe sub directory #149

Merged
merged 1 commit into from Sep 13, 2022

Conversation

jordanamr
Copy link
Contributor

Fixes #148

@jordanamr
Copy link
Contributor Author

If anyone is stuck on that issue and rely on that action, we forked and fixed that at our company while the author is away :)
Feel free to use skillupco/github-tag-action@1.39.0-skco

@sammcj
Copy link
Collaborator

sammcj commented Sep 11, 2022

@jordanamr are the $GITHUB_WORKSPACE and $SOURCE variables definitely available inside the containers?

@jordanamr
Copy link
Contributor Author

jordanamr commented Sep 11, 2022

@jordanamr are the $GITHUB_WORKSPACE and $SOURCE variables definitely available inside the containers?

Unsure. They are used and/or defined in the entrypoint.sh.
However, I can confirm that this fix is used in production at our company since April without any issues.

@sammcj sammcj self-requested a review September 11, 2022 22:54
@sammcj
Copy link
Collaborator

sammcj commented Sep 11, 2022

OK thanks @jordanamr, I think it should be OK, I've been added to the list of maintainers for this repo so am happy to approve and merge it, my only concern is that there aren't any tests for this project (yet) so I'm flying blind a bit.

If I was to merge and let it release - would you be happy to switch back to this main repo and confirm that your issue is resolved for me?

@sammcj sammcj self-assigned this Sep 11, 2022
@sammcj sammcj merged commit be89588 into anothrNick:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsafe repository error still present on 1.39.0
2 participants