Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision of locked amounts in shielded token params #3255

Open
sug0 opened this issue May 16, 2024 · 0 comments
Open

Increase precision of locked amounts in shielded token params #3255

sug0 opened this issue May 16, 2024 · 0 comments
Labels
enhancement New feature or request MASP

Comments

@sug0
Copy link
Contributor

sug0 commented May 16, 2024

In the shielded token param struct,

pub struct ShieldedParams {
    pub max_reward_rate: Dec,
    pub kd_gain_nom: Dec,
    pub kp_gain_nom: Dec,
    pub locked_amount_target: u64,
}

locked amounts are represented as u64 values. We should increase their precision to 256 bits, by switching to a Uint here.

This change would break the genesis files, since Uint values are parsed from strings instead of numbers.

@sug0 sug0 added the enhancement New feature or request label May 16, 2024
@sug0 sug0 added this to the Later / optional milestone May 16, 2024
@sug0 sug0 added the MASP label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MASP
Projects
None yet
Development

No branches or pull requests

1 participant