Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better propagation of dry-run tx errors #3240

Open
sug0 opened this issue May 14, 2024 · 0 comments
Open

Better propagation of dry-run tx errors #3240

sug0 opened this issue May 14, 2024 · 0 comments
Labels
client enhancement New feature or request

Comments

@sug0
Copy link
Contributor

sug0 commented May 14, 2024

We often see this pattern in Namada code:

            if request.path == RPC.shell().dry_run_tx_path() {
                super::dry_run_tx(ctx, &request)
            } else {
                self.rpc.handle(ctx, &request)
            }

This is because dry-run tx errors are poorly propagated to the caller. We should come up with a mechanism to better propagate errors.

@sug0 sug0 added enhancement New feature or request client labels May 14, 2024
@sug0 sug0 added this to the Later / optional milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant