Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint dbg and prints #3257

Merged
merged 48 commits into from
May 21, 2024
Merged

lint dbg and prints #3257

merged 48 commits into from
May 21, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented May 16, 2024 •
edited

Describe your changes

closes #3227

also fixes some rust 2018 idioms and missing docs

Indicate on which release or other PRs this topic is based on

#3214

diff: https://github.com/anoma/namada/pull/3257/files/860132bdfce5e91864bc07808610a39289bd2797..a1c534c52efcf0d8a2797a6f3b976ef6e831b7d2

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic
replay_protection: add lints
7eb5a92
@tzemanovic
events: add lints
61a5661
@tzemanovic
events: use checked arith
6c1c993
@tzemanovic
crates: update for checked events gas
6270249
@tzemanovic
merkle_tree: add lints
4ad1799
@tzemanovic
merkle_tree: fix lints warning
20a449a
@tzemanovic
gas: add lints
c95b5c4
@tzemanovic
gas: fix lints warning
0e70ede
@tzemanovic
tx: add lints
1b35096
@tzemanovic
tx: fix lints warnings
8f108b6
@tzemanovic
vote_ext: add lints
34c0c13
@tzemanovic
storage: add lints
8e06346
@tzemanovic
storage: fix lint warnings
b2ca880
@tzemanovic
controller: add lints
0103ec0
@tzemanovic
controller: fix lint warnings
9bd7fac
@tzemanovic
parameters: add lints
c0e4ae7
@tzemanovic
trans_token: add lints
5134a6d
@tzemanovic
shielded_token: add lints
e0e16b2
@tzemanovic
shielded_token: fix lint warnings
1487ad7
@tzemanovic
account: add lints
a4c1edf
@tzemanovic
account: fix lint warnings
a9783e4
@tzemanovic
governance: add lints
f779c9d
@tzemanovic
governance: fix lint warnings
ff19367
@tzemanovic
proof_of_stake: add lints
c0938a0
@tzemanovic
proof_of_stake: fix lint warnings
7d9b4c5
@tzemanovic
token: add lints
9b344a5
@tzemanovic
token: fix lint warnings
3008e1a
@tzemanovic
state: add lints
2f7ed72
@tzemanovic
state: fix lint warnings
9ee3016
@tzemanovic
vm_env: add lints
293b5ca
@tzemanovic tzemanovic marked this pull request as ready for review May 16, 2024 11:50
@codecov Codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 73.34184% with 209 lines in your changes are missing coverage. Please review.

Project coverage is 60.26%. Comparing base (4ed6229) to head (a1c534c).

Files Patch % Lines
crates/namada/src/vm/host_env.rs 82.01% 25 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 60.52% 15 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 13 Missing ⚠️
crates/namada/src/ledger/vp_host_fns.rs 63.33% 11 Missing ⚠️
crates/tx/src/types.rs 68.57% 11 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 70.96% 9 Missing ⚠️
crates/governance/src/cli/validation.rs 0.00% 9 Missing ⚠️
crates/apps/src/lib/config/genesis/chain.rs 33.33% 8 Missing ⚠️
crates/apps/src/lib/node/ledger/mod.rs 0.00% 8 Missing ⚠️
crates/namada/src/ledger/mod.rs 38.46% 8 Missing ⚠️
... and 28 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
+ Coverage   60.24%   60.26%   +0.02%     
==========================================
  Files         303      303              
  Lines       93191    93453     +262     
==========================================
+ Hits        56145    56323     +178     
- Misses      37046    37130      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone
brentstone approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brentstone added a commit that referenced this pull request May 16, 2024
@brentstone
Merge branch 'tomas/lint-dbg-and-prints' (#3257)
9da7e5d 
* tomas/lint-dbg-and-prints:
  changelog: add #3257
  fix lint warnings
  add lints for dbg and prints (except for in tests)
@brentstone brentstone mentioned this pull request May 16, 2024
Closed
brentstone added a commit that referenced this pull request May 21, 2024
@brentstone
Merge branch 'tomas/lint-dbg-and-prints' (#3257)
000eb2a 
* origin/tomas/lint-dbg-and-prints:
  changelog: add #3257
  fix lint warnings
  add lints for dbg and prints (except for in tests)
@tzemanovic tzemanovic merged commit 8cb095c into main May 21, 2024
17 of 19 checks passed
@tzemanovic tzemanovic deleted the tomas/lint-dbg-and-prints branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentstone brentstone brentstone approved these changes

Assignees
No one assigned
Labels
merged to draft ready for draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a lint to warn about dbg_macro
2 participants
@tzemanovic @brentstone