Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to tendermint-rs 0.36 #3233

Merged
merged 7 commits into from
May 21, 2024
Merged

Bump to tendermint-rs 0.36 #3233

merged 7 commits into from
May 21, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented May 13, 2024

Describe your changes

closes #3225

  • tendermint-rs v0.36
  • tower-abci v0.14
  • ibc-rs v0.53 (not released yet) [blocked]
    • Refactored with ibc-derive to use #[derive(IbcClientState)]
  • masp with bip0039 v0.12 [For building Hermes with Namada]

Indicate on which release or other PRs this topic is based on

v0.35.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 26.56250% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 60.40%. Comparing base (4ed6229) to head (9087cac).

Files Patch % Lines
crates/events/src/extend.rs 0.00% 23 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 17 Missing ⚠️
crates/core/src/uint.rs 0.00% 3 Missing ⚠️
crates/events/src/lib.rs 0.00% 2 Missing ⚠️
crates/ibc/src/context/client.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
+ Coverage   60.24%   60.40%   +0.16%     
==========================================
  Files         303      303              
  Lines       93191    92745     -446     
==========================================
- Hits        56145    56027     -118     
+ Misses      37046    36718     -328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman
Copy link
Member

is this ready?

@yito88 yito88 marked this pull request as ready for review May 15, 2024 18:49
@yito88 yito88 requested a review from sug0 May 15, 2024 18:49
crates/events/src/extend.rs Outdated Show resolved Hide resolved
crates/ibc/src/event.rs Show resolved Hide resolved
yito88 added a commit that referenced this pull request May 17, 2024
tzemanovic added a commit that referenced this pull request May 20, 2024
* origin/yuji/tendermint-0.36:
  check event attribute parsing result
  fix test
  update masp
  add changelog
  for clippy
  ibc-rs 0.53
  bump to tendermint-rs 0.36
brentstone added a commit that referenced this pull request May 21, 2024
* origin/yuji/tendermint-0.36:
  check event attribute parsing result
  fix test
  update masp
  add changelog
  for clippy
  ibc-rs 0.53
  bump to tendermint-rs 0.36
@tzemanovic tzemanovic merged commit c8628ef into main May 21, 2024
16 of 19 checks passed
@tzemanovic tzemanovic deleted the yuji/tendermint-0.36 branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump tendermint-rs to 0.36
4 participants