Sorry, I think the terminology here may be confusing.

The "autosync" setting is about syncing on program open/close. The issue on #3130 was about errors popping up when the "periodically sync media" option is enabled - the one run by on_autosync_timer(). We want to show errors for the former, but not for the latter.

...so confusing that I appear to have confused myself. ^_^; I now see that you're only passing in True in _maybe_auto_sync_media. So it looks like this is already ok? It might be nice to rename is_autosync to is_periodic_sync to hopefully avoid confusion in the future.

Thanks Abdo!