-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize type-in preview strings #3034
Conversation
38cd493
to
cd2c8f7
Compare
ftl/core/card-templates.ftl
Outdated
@@ -61,4 +61,5 @@ card-templates-restore-to-default = Restore to Default | |||
card-templates-restore-to-default-confirmation = This will reset all fields and templates in this notetype to their default | |||
values, removing any extra fields/templates and their content, and any custom styling. Do you wish to proceed? | |||
card-templates-restored-to-default = Notetype has been restored to its original state. | |||
|
|||
card-templates-example = example | |||
card-templates-sample = sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the example is intended to show how comparison works, can we add an explanation for translators so that they pick a good example in their languages, instead of literally translating the strings?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added them. Thanks for the push!
e6bf7b8
to
332164c
Compare
this also fixes the given and expected answers' order
I'm a bit concerned that even with translation hints (which was a good suggestion), translators might struggle to come up with two distinct words/phrases that produce an easily-understandable typing comparison. In the past, Anki used "example" and "exomple", and more than one person filed a bug report thinking that we'd accidentally misspelled it! It doesn't really even need to be English. If you feel that using English words there is unfair to other language speakers, we could use something like "12345" and "12245" instead. WDYT? |
Maybe reverse the two? Otherwise I think that looks ok, and bypasses all the translation issues. What do you think? |
When I read Maybe something extra could be added into the question box to make that clearer. like |
We can't easily inject text outside of the typing area - it would need fragile logic that looks for the input/code sections. I think we're probably either going to need to stick to numbers, or the existing hard-coded English, unless someone has another suggestion. |
I meant inside the type box.
or
then in the answer
|
I was wrong about injecting the text - we're looking for |
I think the second is the clearest. What do you think about changing the wording to something like "Example typed text:"? |
I actually don't like very much any of the results. I'm not going to have time for this for a while, so I'll close the PR for now |
also corrects the provided/expected strings comparison: