Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize type-in preview strings #3034

Closed
wants to merge 1 commit into from

Conversation

BrayanDSO
Copy link
Contributor

@BrayanDSO BrayanDSO commented Feb 25, 2024

also corrects the provided/expected strings comparison:

image

@BrayanDSO BrayanDSO force-pushed the previewer_strings branch 2 times, most recently from 38cd493 to cd2c8f7 Compare February 25, 2024 19:17
@@ -61,4 +61,5 @@ card-templates-restore-to-default = Restore to Default
card-templates-restore-to-default-confirmation = This will reset all fields and templates in this notetype to their default
values, removing any extra fields/templates and their content, and any custom styling. Do you wish to proceed?
card-templates-restored-to-default = Notetype has been restored to its original state.

card-templates-example = example
card-templates-sample = sample
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the example is intended to show how comparison works, can we add an explanation for translators so that they pick a good example in their languages, instead of literally translating the strings?

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added them. Thanks for the push!

@BrayanDSO BrayanDSO force-pushed the previewer_strings branch 4 times, most recently from e6bf7b8 to 332164c Compare February 25, 2024 20:10
this also fixes the given and expected answers' order
@dae
Copy link
Member

dae commented Feb 26, 2024

I'm a bit concerned that even with translation hints (which was a good suggestion), translators might struggle to come up with two distinct words/phrases that produce an easily-understandable typing comparison. In the past, Anki used "example" and "exomple", and more than one person filed a bug report thinking that we'd accidentally misspelled it! It doesn't really even need to be English. If you feel that using English words there is unfair to other language speakers, we could use something like "12345" and "12245" instead. WDYT?

@BrayanDSO
Copy link
Contributor Author

Looks like this now:

image

image

@dae
Copy link
Member

dae commented Feb 27, 2024

Maybe reverse the two? Otherwise I think that looks ok, and bypasses all the translation issues. What do you think?

@BrayanDSO
Copy link
Contributor Author

When I read 123 at the type-in box in the question, I can associate that it is an example, but not so much with 124.

Maybe something extra could be added into the question box to make that clearer. like example: 123 and then compare 123 to 124 normally in the answer, but I'm really not sure of that

@dae
Copy link
Member

dae commented Feb 28, 2024

We can't easily inject text outside of the typing area - it would need fragile logic that looks for the input/code sections. I think we're probably either going to need to stick to numbers, or the existing hard-coded English, unless someone has another suggestion.

@BrayanDSO
Copy link
Contributor Author

BrayanDSO commented Feb 28, 2024

I meant inside the type box.

1234 (example)

or

example: 1234

then in the answer

1234
 I
 V
1235

@dae
Copy link
Member

dae commented Feb 28, 2024

I was wrong about injecting the text - we're looking for [type: already, which should be pretty unambiguous. So we could inject that text into the typing area. But don't you think it would be clearer to include it on a previous line, so it's more obvious what text was 'typed'?

@BrayanDSO BrayanDSO marked this pull request as draft February 28, 2024 18:40
@BrayanDSO
Copy link
Contributor Author

some options:

image

image

image

@dae
Copy link
Member

dae commented Mar 2, 2024

I think the second is the clearest. What do you think about changing the wording to something like "Example typed text:"?

@BrayanDSO
Copy link
Contributor Author

I actually don't like very much any of the results. I'm not going to have time for this for a while, so I'll close the PR for now

@BrayanDSO BrayanDSO closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-in-answer preview has hardcoded strings
3 participants