fix(client): fix detection of Angular context after string interpolation #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably still has its own issues but seems to be at least an improvement over past scanner issues. It may be good to spend more time on the correctness of this or just `ts.createSourceFile`. This previously wasn't done due to perfomance concerns. fixes angular#1872
clydin
approved these changes
Sep 13, 2023
atscott
added a commit
that referenced
this pull request
Sep 22, 2023
…ion (#1922) This probably still has its own issues but seems to be at least an improvement over past scanner issues. It may be good to spend more time on the correctness of this or just `ts.createSourceFile`. This previously wasn't done due to perfomance concerns. fixes #1872 (cherry picked from commit bd6282e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably still has its own issues but seems to be at least an improvement over past scanner issues.
It may be good to spend more time on the correctness of this or just
ts.createSourceFile. This previously wasn't done due to perfomance concerns.fixes #1872